Remove cmake, make the conda recipe architecture independent #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyStegeman
reviewed
Mar 5, 2024
RoyStegeman
approved these changes
Mar 5, 2024
comane
reviewed
Mar 5, 2024
RoyStegeman
force-pushed
the
definitively_remove_cmake
branch
from
ad769c9
to
3598c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this works I'd be so happy.
This is a necessary step for #1965. if the test pass here rebasing on top of this could (I hope) make your tests pass as well without further changes @comane